Like other functions, argument value(s) (instance name) should be allowed to be wrapped in single or double quotes. Previously only singles quotes worked.
Why is this the best possible solution? Were any other approaches considered?
Uses existing XML generation function. Not sure why there was an f-string used before, maybe some kind of conflict with something else that has since been resolved.
What are the regression risks?
It's more consistent with the rest of pyxform now, but maybe some users don't want XML escapes here. As shown in the updated tests, other characters that will be escaped now are <>&.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
[x] included test cases for core behavior and edge cases in tests
[x] run python -m unittest and verified all tests pass
[x] run ruff format pyxform tests and ruff check pyxform tests to lint code
[x] verified that any code or assets from external sources are properly credited in comments
Closes #707
Like other functions, argument value(s) (instance name) should be allowed to be wrapped in single or double quotes. Previously only singles quotes worked.
Why is this the best possible solution? Were any other approaches considered?
Uses existing XML generation function. Not sure why there was an f-string used before, maybe some kind of conflict with something else that has since been resolved.
What are the regression risks?
It's more consistent with the rest of pyxform now, but maybe some users don't want XML escapes here. As shown in the updated tests, other characters that will be escaped now are
<>&.Does this change require updates to documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
testspython -m unittestand verified all tests passruff format pyxform testsandruff check pyxform teststo lint code