XLabs-AI / x-flux-comfyui

Apache License 2.0
1.06k stars 71 forks source link

XLABS sampler is slower than ksamper #100

Open starinskycc opened 2 months ago

starinskycc commented 2 months ago

I tested it in Comfyui, XLABS sampler is slower than ksamper

starinskycc commented 2 months ago

image 1

LuckyNES commented 2 months ago

I agree. It is much slower. I would like to be able to use the controlnets with KSampler if possible or for XSampler to expose the choice to choose sampler_name like KSampler has. Also the results I get from XSampler are much WORSE than if I use deis in KSampler.

F0xbite commented 1 month ago

I've noticed this too. It's about 2x slower than standard Ksampler.

It's definitely the sampler and not controlnet, because using the xlabs sampler without controlnet still takes 2x as long.

valaxy commented 1 month ago

agree, I thought it's my PC's problem, finally find Xlabs Sampler's

ewebgh33 commented 1 month ago

I can't find a way to get the same result out of Xlabs Sampler vs KSampler, or Xlabs Sampler vs SamplerCustomAdvaced. WHY is Xlabs sampler even a thing? There is an established workflow for using controlnets, with either KSampler or SamplerCustomAdvanced. Why now introduce yet another (inferior) node?

enesaltinkaya commented 5 days ago

When I set timestep_to_start_cfg equals or more than the steps, it runs as fast as ksampler.

You know how we set cfg to 1 when using flux with ksampler, timestep_to_start_cfg must be setting it more than 1, so it slows down.

Stardesign2024 commented 4 days ago

When I set timestep_to_start_cfg equals or more than the steps, it runs as fast as ksampler.

You know how we set cfg to 1 when using flux with ksampler, timestep_to_start_cfg must be setting it more than 1, so it slows down.

Thanks!