XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 37 forks source link

[bug] Warning "Sanctioned target address" is no longer displayed after network is changed #1008

Closed tsadovska closed 3 months ago

tsadovska commented 3 months ago

Is there an existing issue for this?

Current Behavior

Warning "Sanctioned target address" is no longer displayed after network is changed. Please use this link to view the recording.

image

Expected Behavior

Warning "Sanctioned target address" is displayed.

Steps To Reproduce

  1. Open https://preview.portalbridge.com/859350d189/
  2. Prepare to send 0.01 AVAX from Avalanche (MetaMask) to Fantom (Wallet address from https://github.com/ultrasoundmoney/ofac-ethereum-addresses, 0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a)
  3. Click on "Approve and proceed with transaction" button
  4. Change Fantom network to Celo
  5. Click on "Approve and proceed with transaction" button
  6. Check if warning "Sanctioned target address" is displayed

Environment

- OS: macOS Sonoma 14.5
- Wallet: MetaMask
- Browser: Google Chrome Version 127.0.6533.100 (Official Build) (arm64)

Anything else?

No response

danielisaacgeslin commented 3 months ago

@tsadovska I believe this behavior is correct. Same addresses might be sanctioned on one chain, but not others.

You can check this address 0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a transferring to ethereum and then arbitrum and you'll find it's sanction on both those chains, but not in avalanche.

yuli-ferna commented 3 months ago

@danielisaacgeslin, what you say is true, but for now, to avoid interacting with sanctioned wallets, I am consulting on Ethereum also when it is an evm.

@tsadovska This should be fixed

https://github.com/user-attachments/assets/68cf67f5-c5fc-4058-b5c2-286929ef924a

tsadovska commented 3 months ago

Tested OK on https://portalbridge.com/. Warning "Sanctioned target address" is displayed when account from https://github.com/ultrasoundmoney/ofac-ethereum-addresses page is entered. Ticket is closed.