XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 36 forks source link

[support] [ticket 8602] - sui usdc to polygon cannot be redeemed #328

Closed ss3388 closed 1 year ago

ss3388 commented 1 year ago

Is there an existing issue for this?

have you checked our wiki for common solutions?

Operation Details

- Source Chain: sui
- Source Chain Wallet: 0x01cfece511ac99f26ccdb1b395d9b18300527991f81cd42905ef12ddc7da2575
- Target Chain: polygon
- Target Chain Wallet:0x461a8878060aa45fa685732bff654ca1fdef2830
- Asset Type: token 
- Tx:3Tp3iRzogdk9ekf57kaz8f1BdM2FmqG5t6hj64yv9hid

Current Behavior

User is not able to redeem

error when redeeming: cannot estimate gas; transaction may fail or may require manual gas limit [ See: https://links.ethers.org/v5-errors-UNPREDICTABLE_GAS_LIMIT ] (reason="execution reverted: invalid sender", method="estimateGas", transaction={"from":"0x1C9Ed9D422B357C96B36b66C842037b9B0F0A1b9","to":"0x5a58505a96D1dbf8dF91cB21B54419FC36e93fdE","data":"0xc68785190000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000047901000000030d00ebb12eff47c46b9cb60bc816a60e7efa60abeedcf863c5c0cb2037c9aa1b58e750b526e79bff669beaadb8dd04433e2cc78bca2c410d268eeb7f44928c183e07000115bb827909e352ac3b40b2a3ea6e4451f49314f0d60d17459de26047a5ae00290e05162cefdb3ebd235e225ceeab1558c0bd396b0cc3ad3443c8f79c52bb4ff00002ac3b9820e3eb5ea1074472674539a2a5a9469dfdf8acb5da4f606440714cdfb052179d40ff7042d575a997134e1b78603e675657454a071e71f3b7575a23e6630103986c3b08b2217d546d3c4629bda4a67d5f1d93dd82dbb62b032fa893d1b526556cfe0fc1560aea32077b624364e3ef64112782ed91707b3846a690b4ccd8c1c50004792fdc8e652dc6c46eb2c0ff551e41ba30ad5b5d3f9265b53872a62342720b3d4ad0f39bb36d65acdd5ef57c71def5061c93bca04082124868020b1232e940a000062e74a18effaefbb867498aaefb4ed1ae39fcc8873e87b2ece7d237b4dc7ba22c68ebfb6fe087de38de4c1e06c8ce9dfd243194bd5f9626a7b05852e77b881e7e010a3e9d417d3409b1d8d9074024dc87584791cfc7cd02f5e2b364ca9ae3ffee2b1a0b8c09d18c4b912b5fda92a08dcfa825996e6a3ad685f46dcd153f5991383a84010b74980b03440a489486756ef52a4685eba565b37e072e34d2c5db2c0b3f104ce9280b45c7de672bbc7a28a163db778814162847b46206b7faccfc4b65952f9727000ddf6e1c4783c4b1a756b56ec4ff9883f4ed4a3ad42174ff4c9711edd34fbf6a402da0b6537cb78940f45a50ad3833b0b930259fb5390903075bee7448f1f992c5010e593bc027210fbc743840bfc8778e6db5917c3642192ca607e3718f950a5c3e2e20eb9363cb7cd264c014aaf938bad2606d002d865dead796458c5b47264687110110cc26f6d5d8adf0bb90165d5a67f82976e1d92ed917f6dbf55920a4d5a6b0146c28bcd74933fd51111ee637f1775f3cb823b9089796df315c6a8d5f7be9e94ca10011719b341c2e2e13945fd5741ca0d3516ad0d2655c955a0022dd9fb91c804645ac600d97c8e1d682238f3ef093e6dc1463a144b5382bd319cfc2dff770a00b8494001259c59642bf1a3f1961595e573dca3f74078778305c280d6e4113c26c5568be1941561271a7a7b166232fdf15616a72479519964faef1fed971ef064b217cd1d40064d72c14000000750015ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5000000000000280b0003000000000000000000000000000000000000000000000000000000000b76e020000000000000000000000000a0b86991c6218b36c1d19d4a2e9eb0ce3606eb480002000000000000000000000000461a8878060aa45fa685732bff654ca1fdef2830000544cd5861a6732696d2122e5d1123c3b86c8146c2fe78fd957378fc9ce28b9c41010000000000000000000000000000000000000000000000000000000000124f800000000000000000000000000000000000000000000000000000000000000000000000000000000000000000c136559f0d1706848d90f64ce1cd2ecc1518c3ba00000000000000","accessList":null}, error={"code":-32603,"message":"Internal JSON-RPC error.","data":{"code":3,"message":"execution reverted: invalid sender","data":"0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000``

Expected Behavior

Steps To Reproduce

No response

Anything else?

No response

dry2022 commented 1 year ago

ticket 8897 -

tx DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm

SUI -> BSC

same issue

drisAloma commented 1 year ago

(SUI -> Polygon #Ticket-8602) transaction has to redeemed manually, I will post it on slack.

(SUI -> BSC #Ticket-8897) transaction recipient's address is pointing to a contract, I think it might have to be relayed manually as well. There are two other pending transactions like this (SUI -> Polygon):

Ticket #8762 Tx - CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4

Ticket #8915 Tx - Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy

Contract address: 0xCafd2f0A35A4459fA40C0517e17e6fA2939441CA

sebastianscatularo commented 1 year ago

@drisAloma @dry2022 what was the dApp used to perform those txs? Was it portalbridge.com/sui?

drisAloma commented 1 year ago

One of them used SUISWAP, will check in with others

willis20188 commented 1 year ago

ticket 8897 -

tx DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm

SUI -> BSC

same issue

Use: https://app.naviprotocol.io/bridge.

willis20188 commented 1 year ago

Hello! any update ?

sebastianscatularo commented 1 year ago
txHash source target emitter was emitted by token bridge? Summary Scanner
3Tp3iRzogdk9ekf57kaz8f1BdM2FmqG5t6hj64yv9hid Sui Polygon 21/ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/10251 no sui token bridge contract 0xc57508ee0d4595e5a8728974a4a93a787d38f339757230d441e895422c07aba9 differ from ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5 https://wormholescan.io/#/tx/3Tp3iRzogdk9ekf57kaz8f1BdM2FmqG5t6hj64yv9hid
DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm Sui Bsc 21/ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/11200 no sui token bridge contract 0xc57508ee0d4595e5a8728974a4a93a787d38f339757230d441e895422c07aba9 differ from ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5 https://wormholescan.io/#/tx/DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm
CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4 Sui Polygon 21/ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/10623 no sui token bridge contract 0xc57508ee0d4595e5a8728974a4a93a787d38f339757230d441e895422c07aba9 differ from ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5 https://wormholescan.io/#/tx/CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4
Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy Sui Polygon 21/ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/11152 no sui token bridge contract 0xc57508ee0d4595e5a8728974a4a93a787d38f339757230d441e895422c07aba9 differ from ccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5 https://wormholescan.io/#/tx/Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy

Conclusion

A different contract emitted all the tx, and the user should contact the app owner for assistance, The VAA emitted seems to be incompatible with the token bridge contract, which is why it is failing at the redemption step.

drisAloma commented 1 year ago

Noted @sebastianscatularo Thank you! Just to add, we were able to manually redeem the first transaction on table on our end, though it was the only one pointing to another contract address as recipient. Contract address: 0x461a8878060Aa45Fa685732bfF654Ca1FDeF2830 Which is due to the deprecated npm version.

dry2022 commented 1 year ago

Hello! @sebastianscatularo a bunch of user are still having this problem, the MOD from suiswap just opened a ticket saying that user are complaining about this. What can we do for them?

ss3388 commented 1 year ago

Just adding this transaction from sui to polygon as well : Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy

sebastianscatularo commented 1 year ago

my first analysis was wrong, only the first transaction is through a legacy contract, the other should be relayed automatically by relayers

txHash source target type Scanner Target  
tr Sui Polygon transfer with payload https://wormholescan.io/#/tx/3Tp3iRzogdk9ekf57kaz8f1BdM2FmqG5t6hj64yv9hid https://github.com/wormhole-foundation/wormhole-connect/pull/662/files#diff-3242bdbdeea1ae665e6580254a696ffd67ffb4a12b21ca1650885a2bf533dc72L48 Legacy
DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm Sui Bsc transfer with payload https://wormholescan.io/#/tx/DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm https://github.com/wormhole-foundation/wormhole-connect/pull/662/files#diff-3242bdbdeea1ae665e6580254a696ffd67ffb4a12b21ca1650885a2bf533dc72R58 Non Legacy
CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4 Sui Polygon transfer with payload https://wormholescan.io/#/tx/CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4 https://github.com/wormhole-foundation/wormhole-connect/pull/662/files#diff-3242bdbdeea1ae665e6580254a696ffd67ffb4a12b21ca1650885a2bf533dc72R48 Non Legacy
Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy Sui Polygon transfer with payload https://wormholescan.io/#/tx/Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy https://github.com/wormhole-foundation/wormhole-connect/pull/662/files#diff-3242bdbdeea1ae665e6580254a696ffd67ffb4a12b21ca1650885a2bf533dc72R48 Non Legacy

@scnale @solanoepalacio could you check them?

scnale commented 1 year ago

We identified an issue that impacts users who (both must hold to be impacted):

We have a plan to fix new and past Sui transfers in these outdated applications but its execution is in progress. I'd like to remind everyone that support for these old versions of wormhole connect is a best effort endeavour and the applications should be updated to enjoy full support and a better user experience.

drisAloma commented 1 year ago

Hello, (ticket-9322) Another transaction has the same issue but this time it was via portalbridge.com/sui @sebastianscatularo .

Source: SUI Target: Polygon Tx: 3ynTKNgxtWmJKLKBgGeSDK7bC3G9de3SXvBvBg8QqTr1

Recipient address: 0xCafd2f0A35A4459fA40C0517e17e6fA2939441CA

However, the transaction shows "Success! The redeem transaction was submitted." on the redeem tab. Could this just be a delay with the relayer?

drisAloma commented 1 year ago

All good with this transaction.

drisAloma commented 1 year ago

Hello, All the previously reported transactions now show "Success! The redeem transaction was submitted." but yet to reflect in the users' addresses.

scnale commented 1 year ago

Hm, I'm not sure why you saw a success message for DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm, CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4 or Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy before. I redeemed those with a special procedure just now. Details:

- Relayed chainId=4, txHash=0x2f16733388899347001a9ee870eab1f16d2f417808996fc35752fa14b31d5c74, 
vaa id: 21/0xccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/11200
original txHash=DzHxQp66NmJdjQB8FFezjBGLcpgVFsAFp4oxTPuvPZKm

- Relayed chainId=5, txHash=0x362bc47f4a7ad09b15afa2d1b4dade7c0e45b08ec713338bf9f7c369f15503d6,
vaa id: 21/0xccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/10623
original txHash=CKMhisUgDmLTmhBVcJZGEJ9CEtLDobWiE8nq5L4kNni4

- Relayed chainId=5, txHash=0x3df80fba233c6169cb5c7990832a162685d7b0d0af54a0dec612c01ea03b5190
vaa id: 21/0xccceeb29348f71bdd22ffef43a2a19c1f5b5e17c5cca5411529120182672ade5/11152
original txHash=Ae2Jh7LhXjRexXUDxhcnqNL99Hhcp314VpeysTJsMqZy
drisAloma commented 1 year ago

Oh, okay, Thank you!