search

XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
20 stars 33 forks source link

[feat] Add XDEFI Wallet to the list of supported wallets #460

Open d231d opened 9 months ago

d231d commented 9 months ago

Scenario

Currently, the XDEFI Wallet does not appear as an option in the Portal UI - the only workaround is to open the browser plugin, prioritize XDEFI over Metamask, and then click on the Metamask icon in the Portal wallet selection field. This is almost impossible to find out for a user on their own, so XDEFI is virtually not supported atm.

Acceptance Criteria

XDEFI Wallet should be added as a "regular" option to the list of supported wallets without needing the above-mentioned workaround.

Anything else?

No response

sebastianscatularo commented 6 months ago

we are using https://github.com/XLabs/wallet-aggregator-sdk to support wallets, first is going to be needed to add support there first

kdenhartog commented 6 months ago

I just opened an issue over there to add EIP-6963 support instead. This will make it easier to integrate more wallets since you'll be able to automatically detect the wallets available. I believe xDEFI is already supporting this standard as well so you wouldn't need to add specific support for them or other wallets.