XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 38 forks source link

[bug] Incorrect error notification displayed for invalid manual wallet address input #964

Closed agodlevska closed 3 months ago

agodlevska commented 3 months ago

Is there an existing issue for this?

Current Behavior

A notification "Error with transfer, please try again" appears when user enter invalid wallet address.

Expected Behavior

A notification message should inform the user that the entered wallet address is not valid - "Not valid target address".

Steps To Reproduce

  1. Open https://preview.portalbridge.com/859350d189/.
  2. Prepare to send 0.001 ETH from Ethereum (MetaMask) to BSC (invalid wallet address)
  3. Manually input an incorrect wallet address.
  4. Click on "Approve and proceed with transaction" button.

Environment

- OS: macOS Sonoma 14.5
- Wallet: MetaMask, invalid wallet address input
- Browser: Google Chrome Version 127.0.6533.89 (Official Build) (x86_64)

Anything else?

The console logs correctly indicate that the wallet address is invalid.

Screenshot 2024-08-02 at 10 02 41
yuli-ferna commented 3 months ago

@agodlevska could you give me the invalid address that you use in this test? :)

agodlevska commented 3 months ago

@yuli-ferna sure! I used a my half-erased wallet address, for example, 0xd493066498aCe4cffE01. I don’t remember exactly up to which point it was erased, but it was something like this.

yuli-ferna commented 3 months ago

It should work now :)

image

with this version:

image
agodlevska commented 3 months ago

Checked on https://preview.portalbridge.com/859350d189/ v0.2.15-P2b952cbfb3. The issue is no longer reproducible. The notification message is "Not valid target address" when user enters the invalid wallet address. Closing the ticket.

Attachment:

Screenshot 2024-08-05 at 10 08 12