XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 38 forks source link

[bug] Cannot find token by contract address #965

Closed tsadovska closed 3 months ago

tsadovska commented 3 months ago

Is there an existing issue for this?

Current Behavior

Search by contract address 3NZ9JMVBmGAqocybic2c7LQCJScmgsAZ6vQqTDzcqmJh shows "No results". Token in Explorer: https://solscan.io/token/3NZ9JMVBmGAqocybic2c7LQCJScmgsAZ6vQqTDzcqmJh

https://github.com/user-attachments/assets/e0e5f7e1-ae05-486e-b074-55a531be95cb

Expected Behavior

Asset is found.

Steps To Reproduce

  1. Select Solana as source chain
  2. Connect Phantom wallet
  3. Open Assets list
  4. Search for WBTC token by contract address "3NZ9JMVBmGAqocybic2c7LQCJScmgsAZ6vQqTDzcqmJh"

Environment

- OS: macOS Sonoma 14.5
- Wallet: Phantom
- Browser: Google Chrome Version 127.0.6533.89 (Official Build) (arm64)
- Build: https://preview.portalbridge.com/859350d189/

Anything else?

No response

danielisaacgeslin commented 3 months ago

@tsadovska the address in the example is incorrect. That was an older bug where assets were always showing addresses in their native chain rather than the one in the selected chain (wrapped)

sebastianscatularo commented 3 months ago

@danielisaacgeslin @tsadovska, just keep in mind that there are native assets with addresses, and those should be searchable. The assets that do not have addresses are the fee payment assets like ETH, BTC, and AVAX. However, the wrapped versions of these assets also exist, and that doesn’t necessarily mean they are Wormhole-wrapped. For instance, WETH is the ERC20 representation of native ETH, but it is not Wormhole-wrapped

danielisaacgeslin commented 3 months ago

https://preview.portalbridge.com/859350d189/

tsadovska commented 3 months ago

Thank you! Issue is no longer reproducible on https://preview.portalbridge.com/859350d189/.

image

Ticket is closed.