XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 38 forks source link

[bug] OFAC Check: Warning "This address is sanctioned" is not shown #987

Closed tsadovska closed 3 months ago

tsadovska commented 3 months ago

Is there an existing issue for this?

Current Behavior

Warning "This address is sanctioned" is not shown.

image

Expected Behavior

Warning "This address is sanctioned" is shown.

Steps To Reproduce

  1. Open https://preview.portalbridge.com/859350d189/
  2. Prepare to send 0.1 AVAX from Avalanche (MetaMask) to Fantom (Wallet address from https://github.com/ultrasoundmoney/ofac-ethereum-addresses, 0x8576acc5c05d6ce88f4e49bf65bdf0c62f91353c)
  3. Check if warning "This address is sanctioned" is displayed

Environment

- OS: macOS Sonoma 14.5
- Wallet: MetaMask, https://github.com/ultrasoundmoney/ofac-ethereum-addresse
- Browser: Google Chrome Version 127.0.6533.89 (Official Build) (arm64)

Anything else?

No response

yuli-ferna commented 3 months ago

@tsadovska The message appears when you click on "Approve and proceed with transaction":

image
tsadovska commented 3 months ago

@yuli-ferna Noticed that warning is not displayed after user clicks on "Approve and proceed with transaction" button with following scenario:

  1. Prepare to send 0.1 USDC from Polygon (MetaMask) to Arbitrum
  2. Manually enter wallet address 0x1da5821544e25c636c1417ba96ade4cf6d2f9b5a (Sanctioned target address)
  3. Click on "Approve and proceed with transaction" button

Actual result: MetaMask notification opens. Please use this link to view the recording.

image

Issue is not reproducible with 0xd882cfc20f52f2599d84b8e8d58c7fb62cfe344b wallet address (also sanctioned target address).

sebastianscatularo commented 3 months ago

I think that is expected, since it is the contract approval before the actual check

yuli-ferna commented 3 months ago

@tsadovska should be fixed :) https://portalbridge.com/

image
tsadovska commented 3 months ago

Tested OK on https://portalbridge.com/. Warning that address is sanctioned is displayed after sanctioned wallet address is entered or after user clicks on "Approve and proceed with transaction" button. Ticket is closed.