search

XLabs / portal-bridge-ui

Portal Bridge UI
https://www.portalbridge.com/
25 stars 35 forks source link

[bug] "Manual Bridge" route becomes unavailable when user enables manual address input without entering a wallet address #998

Closed tsadovska closed 1 month ago

tsadovska commented 2 months ago

Is there an existing issue for this?

Current Behavior

"Manual Bridge" route becomes unavailable when user enables manual address input without entering a wallet address.

https://github.com/user-attachments/assets/20081f1b-7f07-4058-912a-6dde3750dc85

Expected Behavior

"Manual Bridge" route can be chosen because the wallet address was not entered manually.

Steps To Reproduce

  1. Open https://preview.portalbridge.com/859350d189/
  2. Prepare to send 0.001 AVAX from Avalanche (MetaMask) to Aptos (Pontem)
  3. Click on wallet address in "To" section and select "Change wallet" from dropdown menu
  4. Enable Manual Input
  5. Click on "Close" button
  6. Check if "Manual Bridge" route can be selected

Environment

- OS: macOS Sonoma 14.5
- Wallet: MetaMask, Pontem
- Browser: Google Chrome Version 127.0.6533.89 (Official Build) (arm64)

Anything else?

No response

sebastianscatularo commented 1 month ago

should be fixed once https://github.com/wormhole-foundation/wormhole-connect/pull/2349 get merged

tsadovska commented 1 month ago

Re-checked the scenario from the Description:

  1. Open https://preview.portalbridge.com/859350d189/
  2. Prepare to send 0.001 AVAX from Avalanche (MetaMask) to Aptos (Pontem)
  3. Click on wallet address in "To" section and select "Change wallet" option from dropdown menu
  4. Enable Manual Input
  5. Click on "Close" button
  6. Check if "Approve" button is displayed

Actual result: "Manual Bridge" route is available, but "Approve and proceed with transaction" button appears only after user clicks on the route option.

https://github.com/user-attachments/assets/95909fc7-6741-4a0e-9868-5b76961dc783

Issue will be re-checked once https://github.com/XLabs/portal-bridge-ui/issues/1004 is solved.

yuli-ferna commented 1 month ago

@tsadovska This should be fixed and the issue https://github.com/XLabs/portal-bridge-ui/issues/1004 too

https://github.com/user-attachments/assets/db61e056-ba23-4be1-a481-b94e2349eaa2

tsadovska commented 1 month ago

Tested OK on https://portalbridge.com/. "Manual Bridge" route remains available after user enables manual address input without entering a wallet address. Ticket is closed.