XLabs / wormscan-ui

6 stars 3 forks source link

[BUG] TXS warning message in Governor not working correctly #526

Open SamantaCasal opened 9 months ago

SamantaCasal commented 9 months ago

Current Behavior

When is a big txs we are showing the wrong message: Big Tx Eth: https://wormholescan.io/#/tx/0x3b689dbc1adaedb8ee9c5950dbbaf41e5425b2b94af881d8443d23b62496666a

Image

Message displaying

Image

Expected Behavior

The message should be:

Case 2: The transaction stays "IN_PROGRESS", the transaction is not considered a Big Transaction, but the daily limit of the blockchain has been exceeded.

In this case, we should display a message:

Case 3: The transaction stays "IN_PROGRESS" because the transaction is considered a Big transaction. In this case, we should display a message:

"This transaction will take 24 hours to process, as it exceeds the Wormhole network's temporary transaction limit of [$xxx] on [Blockchain] for security reasons". Learn more](https://github.com/wormhole-foundation/wormhole/blob/main/whitepapers/0007_governor.md) about this temporary security measure. "

NOTE: Please, remove in all cases

SamantaCasal commented 8 months ago

QA FAIL:

This transaction should display the message for big tx.

https://dev.wormholescan.io/#/tx/DzBVyoABn1XQRF4UtX1FjeZc4qm1zHMkSZ6VNjT8YAeR

Image

NOTE: to check this fix you can use the txs listed governors https://wormhole-foundation.github.io/wormhole-dashboard/#/

SamantaCasal commented 8 months ago

Big tx: https://xlabs.github.io/wormscan-ui/#/tx/0x49d3853bfd8b768f18d300782bcb4f3e0f0250a77edcd71277eb06334672428f

❗ Limit should be $500,000 instead of $500000 ( "," is missing)

Image

Image

ARB tx: https://xlabs.github.io/wormscan-ui/#/tx/0xf0eef7cbc6d2310414b6ff87869e531fe0ffb05428016c5e21725fc659e068db

Image