XLabs / wormscan-ui

5 stars 3 forks source link

Enhance Transaction Details and Signature Tracking on WormholeScan #647

Open SamantaCasal opened 2 months ago

SamantaCasal commented 2 months ago

User Story:

As a user of WormholeScan, I want the platform to automatically search for transactions in the Observations if they are not found in the operations endpoint so that I can view detailed transaction pages even for unlisted transactions. I also want to see detailed signature counts and guardian information to better understand the validation process and the roles of the guardians.

Acceptance Criteria:

Resources

Endpoint: https://api.staging.wormscan.io/api/v1/observations?txHash=0xc4a112d0c9298a9f337194b87c1eadaf13b2a377f0b03c000e41b69c921e4ba4 Note:Exclude Solana, Aptos, Wormchain.

SamantaCasal commented 1 week ago

Comments: FYI: @valentinoConti ❗ Fail: Fallback Transaction Search: When the operations endpoint does not find a transaction, the system should automatically search within the Observations. If the transaction is located in Observations, the transaction details page should be displayed.

Image

Image

Case: 8 Signed in observations response:

Image

It's showing 0/13

Image

✅ Direct Link to Signed VAA: Clicking on a signature in the transaction details should redirect the user to the Advanced View, specifically the Signed VAA section

SamantaCasal commented 6 days ago

The same behavior mentioned in the previous comment is observed when the user searches by VAA ID. Specifically, this transaction has 6 signatures, but we are displaying 0/13.

Image Image

✅ OK when the user use txHash to search.

https://github.com/XLabs/wormscan-ui/assets/69044575/3e114ce1-8963-48d9-8099-c737824bc5ac

valentinoConti commented 6 days ago

Should be working now for both txHash and vaa-id searches 👍


Also @SamantaCasal,just in case, while doing this I found a transaction where the observations endpoint has 10 signatures (so it would show 10/13 if its observations endpoint its needed) but for the same vaa-id the operations endpoint returns a vaa (which indicates at least 13 guardians signed the txn):

Operations: https://api.staging.wormscan.io/api/v1/operations/4/000000000000000000000000b6f6d86a8f9879a9c87f643768d9efc38c1da6e7/574340?page=0&pageSize=10&sortOrder=ASC Observations: https://api.staging.wormscan.io/api/v1/observations/4/000000000000000000000000b6f6d86a8f9879a9c87f643768d9efc38c1da6e7/574340?page=0&pageSize=10&sortOrder=ASC

Sharing it in case it is a bug

SamantaCasal commented 4 days ago

OK!

Image