XLabs / wormscan-ui

5 stars 3 forks source link

Migrate wormholescan to use new SDK #731

Open SamantaCasal opened 3 months ago

SamantaCasal commented 3 months ago

Description

Source: https://github.com/XLabs/wormscan-ui/issues/689 (Valentino Comment)

This document describes the code changes needed to be able to replace the old wormhole-sdk to the newest one

Steps needed to be done

There are two steps that need to be done for the app to be able to run with the new wormhole-sdk:

  1. Upgrade from ethers@4 to ethers@6: ethers versions are incompatible between them, we can't have both installed, and wormhole-sdk depends on v6. Doing this includes:
  1. Replace every common function from the old sdk to the new sdk: old sdk functions won't work anymore because of the ethers upgrade, so they'll need to be replaced before the app can run. This includes:
valentinoConti commented 3 months ago

Ready to test in https://dev.wormholescan.io/

Everything should work the same except for Standard Relayer transaction which won't load, and operations without information from the API are not going to be get via RPCs; that should work after #734 gets completed

SamantaCasal commented 2 months ago

Most of the transactions tested are OK.

Please review the cases that I mention in the Notes sheet. https://docs.google.com/spreadsheets/d/10otoe2GT5dbeMui4_uWuPGhtX2__d5eY-UONjuqq-a4/edit?usp=sharing