Closed garybuhrmaster closed 1 year ago
garybuhrmaster
commented
2 years ago As mentioned elsewhere, this patch is necessary, but not sufficient (there are other issues in the zz_sdjson grabber). Hopefully an interested party will review the code and propose additional additional fixes.
rmeden
commented
1 year ago looking at old threads.... tv_grab_zz_sdjson works for me. close?
garybuhrmaster
commented
1 year ago looking at old threads.... tv_grab_zz_sdjson works for me. close?
Following redirects is necessary for the new (lambda based) Schedules Direct API endpoint (and does not hurt with the existing API). However, implementation of that endpoint was deferred (perhaps indefinitely?).
Personally, I am happy to have someone else own the responsibility for the future PR should Schedules Direct decide to move forward with their changes.
The new Schedules Direct JSON endpoint may issue a redirect to a S3 bucket. Allow LWP to follow redirects for additional methods.
Thanks for taking the time to open a Pull Request (PR). Please take a moment to review our open/closed PRs above, in case a similar contribution has already been offered.
If you are opening a new Pull Request, please give it a descriptive title and fill out the blanks below, providing as much information as possible.
Pull Requests should be made against our master branch, and rebased if necessary.
What type of Pull Request is this?
Does this PR close any currently open issues?
(If yes, please provide the issue number) …
Please explain what this PR does
This fixes a fetch issue with the new Schedules Direct JSON endpoint.
…
Any other information?
(For example, has this change been discussed on the xmltv-devel mailing list?) …
Where have you tested these changes?
Operating System: …
Linux
Perl Version: …
5.34