search

XMLTV / xmltv

Utilities to obtain, generate, and post-process TV listings data in XMLTV format
GNU General Public License v2.0
266 stars 93 forks source link

EPG provider requires 'User-Agent' value in the request header #193

Closed sinancetinkaya closed 1 year ago

sinancetinkaya commented 1 year ago

Thanks for taking the time to open a Pull Request (PR). Please take a moment to review our open/closed PRs above, in case a similar contribution has already been offered.

If you are opening a new Pull Request, please give it a descriptive title and fill out the blanks below, providing as much information as possible.

Pull Requests should be made against our master branch, and rebased if necessary.

What type of Pull Request is this?

Does this PR close any currently open issues?

(If yes, please provide the issue number)

192

Please explain what this PR does

…

Any other information?

(For example, has this change been discussed on the xmltv-devel mailing list?) …

Where have you tested these changes?

Operating System: …

Perl Version: …

rmeden commented 1 year ago

You're setting the user agent to emulate Firefox.. We shouldn't emulate a browser, but be honest and include a valid user agent. The XMLTV::Get_nice module sets the agent to "xmltv/$XMLTV::VERSION"

If a provider chooses to block us based on the user agent, that means they don't allow us to scrape their site... we should abide by that.

sinancetinkaya commented 1 year ago

Ah, ok then