search

XMLTV / xmltv

Utilities to obtain, generate, and post-process TV listings data in XMLTV format
GNU General Public License v2.0
266 stars 93 forks source link

Fix for Dockerfile smell DL4000 #205

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Thanks for taking the time to open a Pull Request (PR). Please take a moment to review our open/closed PRs above, in case a similar contribution has already been offered.

If you are opening a new Pull Request, please give it a descriptive title and fill out the blanks below, providing as much information as possible.

Pull Requests should be made against our master branch, and rebased if necessary.

What type of Pull Request is this?

Does this PR close any currently open issues?

None

Please explain what this PR does

Hi! The Dockerfile placed at "ci/Dockerfile.ubuntu-cosmic" contains the best practice violation DL4000 detected by the hadolint tool.

The smell DL4000 occurs when the deprecated MAINTAINER instruction is used. In this pull request, we propose a fix for that smell generated by our fixing tool. We verified that the patch is correct before opening the pull request. To fix this smell, specifically, the MAINTAINER instruction is replaced by an equivalent LABEL instruction as recommended by the official guidelines.

This change is only aimed at fixing that specific smell. In the case the fix is not valid or useful, please briefly indicate the reason along with suggestions for possible improvements.

Thanks in advance.

Any other information?

None

Where have you tested these changes?

Only affects Dockerfile

rmeden commented 1 year ago

I think I did this right.. first attempt at a merge! Change looked pretty safe... basically a comment update