tv_grab_uk_tvguide: "NO DATA" in MythTV EPG for programmes that span the transition to BST

mkbloke commented 5 years ago

XMLTV Version?

I am using knowledgejunkie's 0.6.1 Debian Sid packages, but with the latest tv_grab_uk_tvguide perl script from GitHub.

XMLTV Component?

tv_grab_uk_tvguide.

What happened?

As per the subject, the MythTV EPG shows "NO DATA" for programmes that span the transition to BST.

What did you expect to happen?

The EPG data would show in MythTV for, e.g. "Transporter 3" on Channel 4 and "All New Shocking Moments in Pop" on Channel 5.

Did you see any warnings/errors?

N/A.

What steps are needed to reproduce this issue?

(Please provide the full commands you are running)

tv_grab_uk_tvguide --debug --quiet --days 1 --offset 1 --output /tmp/tv_guide_tvguide.xml &> /tmp/tv_guide_tvguide.log
tv_grab_uk_tvguide --debug --quiet --days 1 --offset 2 --output /tmp/tv_guide_tvguide.xml &> /tmp/tv_guide_tvguide.log

mkbloke commented 5 years ago

These programmes appear to have no stop data, e.g.:

`

Transporter 3 (2008)

<desc lang="en">Underworld courier Frank Martin's latest assignment involves transporting the kidnapped daughter of a crooked government minister across Europe on behalf of an eco-terrorist faction. However, a device will kill him if he leaves his car, thugs employed by the politician are out to murder him, and his passenger has a bad case of Stockholm syndrome. Action thriller sequel, with Jason Statham and Natalya Rudakova.</desc>
<date>2008</date>
<category lang="en">Adventure</category>
<category lang="en">Films</category>
<subtitles type="teletext" />
<rating system="BBFC">
  <value>15</value>
</rating>
<star-rating>
  <value>6.3/10</value>
</star-rating>

Teleshopping A chance to buy goods from the comfort of home. Advertisement Shopping

2.4/10

` and: ` All New Shocking Moments in Pop Clare Grogan narrates a selection of scandalous celebrity moments, including Mariah Carey getting caught out lip synching, the online feud between Madonna and Elton John, Brian Harvey's controversial remarks about Ecstasy and Susan Boyle's misguided hashtag. With contributions from Louis Walsh, Sonia, Cheryl Baker and MC Harvey. General Show Game Show

Tenable A family of five from Bath dubbed the Eager Beaverstocks answers questions about top 10 lists from the realms of pop culture and general knowledge, then tries to score a perfect 10 in the final round to take home the prize money. Quiz, hosted by Warwick Davis. Game Show Quiz

2.20/60.

6.5/10

` Compare the first and the next programme in each block. With apologies for the formatting...

honir commented 5 years ago

Thanks for the report.

I've committed a patch which fixes the GMT->BST changeover. But note stop time is an optional attribute, so you should not rely on it being present in the XML output.

XMLTV / xmltv