Moved Dockerfiles to infrastructure/ directory. - Githubissues

XMLTV / xmltv

Utilities to obtain, generate, and post-process TV listings data in XMLTV format

GNU General Public License v2.0

275 stars 93 forks source link

Moved Dockerfiles to infrastructure/ directory. #99

Closed swmcc closed 4 years ago

swmcc commented 4 years ago

What type of Pull Request is this?

[ ] adds new functionality
[ ] fixes/improves existing functionality
[x] Repo cleanup

Please explain what this PR does

I renamed the .Dockerfile-xxx to a infrastructure/Dockerfile-xxx. This removes the need to hide the Dockerfiles in the repo via a dotfile and tidys up the initial look of the repo.

I also amended travis.yml to reference the new path of the Dockerfiles.

Any other information?

If this PR is successful I would want to include how to get XMLTV up and running via docker in the README.md

Where have you tested these changes?

This PR was just a documentation fix, though it does touch on how the project is built in the CI environment.

knowledgejunkie commented 4 years ago

Thanks for the PR, and apologies for not having responded sooner.

A couple of thoughts:

i) there are new and updated Dockerfiles in the repo, so the original PR needs a respin

ii) I think I'd prefer a ci/ directory, rather than an infrastructure/ directory.

swmcc commented 4 years ago

I will rebase and action the items above at the weekend. Thanks for the review.

knowledgejunkie commented 4 years ago

I have just committed the necessary changes to this PR and credited you with the commit.

Thank you for your contribution to XMLTV.