XOOPS / XoopsCore25

XOOPS Core 2.5.x (current release is 2.5.11: https://github.com/XOOPS/XoopsCore25/releases)
GNU General Public License v2.0
71 stars 59 forks source link

More ressources for designers and more comprehensive #793

Closed alain01 closed 4 years ago

alain01 commented 4 years ago

Thank you Richard for the theme xswatch4. The custumization is very clear for me (dark = slate), very comprehensive !

But for more ressource, we could rename xswatch to xswatch-cerulean, and add others themes like : xswatch4-slate, xswatch4-darkly, xswatch4-journal...

If you find this idea good, i could make like 6 or 8 bootswatch themes or... other solutions,

i can add somes directories in the xswatch4 theme, css-slate (not dark), css-darkly, css-journal...

What do you think about that ?

alain01 commented 4 years ago

The 1st solution, it's ready to use it, for inexperimented xoops users !

alain01 commented 4 years ago

But solution 1 : Hard for the maintenance, cause for a modification in ./modules/xxx, we should modify all the xswatch4 themes.

Solution 2 : We could comment in the file theme.tpl the lines :

<link rel="stylesheet" type="text/css" href="<{xoImgUrl}>css-cerulean/bootstrap.min.css"> 
<!-- <link rel="stylesheet" type="text/css" href="<{xoImgUrl}>css-slate/bootstrap.min.css"> -->
<!-- <link rel="stylesheet" type="text/css" href="<{xoImgUrl}>css-darkly/bootstrap.min.css"> -->
<!-- <link rel="stylesheet" type="text/css" href="<{xoImgUrl}>css-journal/bootstrap.min.css"> -->

[mode_dream ] Solution 2 + impove code : possibility to get option in a configuration page to change the xswatch4 theme... [/mode_dream ]

geekwright commented 4 years ago

You seem to have hit on all the points. Your solution 1 would be a maintenance nightmare. Soultion 2 has a lot of moving pieces which makes for user confusion and frustration. Sadly, there is no place in a theme for configuration options like a module would have, so _modedream is going to happen yet.

Here is a compromise that is easy to implement, only has one point to configure and would work with your multiple css directories. It looks llike this:

    <{* pick the css directory you want to use in the assign var="xswatchCss" value below. *}>
    <{* Valid values are css-slate, css-darkly, css-journal... *}>
    <{assign var="xswatchCss" value="css-dark"}>
    <link rel="stylesheet" type="text/css" href="<{xoImgUrl}><{$xswatchCss}>/xoops.css">
    <link rel="stylesheet" type="text/css" href="<{xoImgUrl}><{$xswatchCss}>/bootstrap.min.css">
    <link rel="stylesheet" type="text/css" href="<{xoImgUrl}><{$xswatchCss}>/cookieconsent.css">
geekwright commented 4 years ago

I would also like to have someone give xbootstrap4 some love. That would be some much needed variety.

mambax7 commented 4 years ago

@alain01 , @tad0616 has a module for changing theme settings: https://github.com/tad0616/tad_themes, but it seems to be focused on his theme architecture. Maybe it could be generalized/standardized for all XOOPS themes? Or XOOPS themes adjusted to his architecture?

In the past there were attempts to do created a theme manager module as well, but we never had a fully working module: https://github.com/XoopsModulesArchive/Xoops-TManager by @TarikAmine https://github.com/XoopsModulesArchive/thadmin by Muss (Andricq Nicolas)

Aitor started work on TCM: https://xoops.org/modules/news/article.php?storyid=5706

@bleekk experimented on Themeadmin, but I don't think, he ever finished it.

@bitcero has also created a very nice theme manager for his theme framework: https://github.com/bitcero/xthemes

@angelorocha started this module, but never finished it: https://github.com/angelorocha/xthemes

It would be definitely nice to have a module as part of Core, where we could modify the theme settings

alain01 commented 4 years ago

@geekwright

@mambax7 Thank for theses links.

With my approach, 3 stages :

mambax7 commented 4 years ago

@alain01 I've added the TCM module to our Archive, in case somebody wants to improve it: https://github.com/XoopsModulesArchive/tcm

And please add your AdminLTE to your account on GitHub, so we can test it...

mambax7 commented 4 years ago

@geekwright reg. xbootstrap4, I'll need to look at your changes from xswatch to xswatch4 and see if I can make similar changes to xbootstrap4 Please share your experience with your conversion and what should we pay attention to...

alain01 commented 4 years ago

And please add your AdminLTE to your account on GitHub, so we can test it...

Sure, but i need to work on it more before to put on github.

mambax7 commented 4 years ago

@alain01 , I've made some updates to the TCM, but they are not very much tested: https://github.com/mambax7/tcm

alain01 commented 4 years ago

I continue my hard work on your xswatch(4), i have commited new templates for mxnews with lot of design depending media size But this work should run on xbootstrap4 theme and for all themes using bootsrap4.

See new templates (+ customize for monxoops.fr)

Blocs : Annotation blocs

Index - articles Annotation index articles

1 article Annotation article

alain01 commented 4 years ago

https://github.com/XOOPS/XoopsCore25/pull/798