Pb with xswatch 4 - "21 themes in 1"

[alain01]

Hi, For the merge https://github.com/XOOPS/XoopsCore25/pull/798 i found a bug and gmage found where is this bug.

I made a xswatch4 package for xoops 2.5.10 with this advice by Richard.

I deleted the css directory /css cause we dont use it (for xoops 2.5.10, webmasters had never used xswacht4 or xswatch4 21themes on 1). But i found a trouble with the MP page "send new message" See :

gmage find some things

• If i add the /css/xoops.css file, it's ok Strange when i used css-cerulean ok another directory !!!

gmage found that the problem come from the /modules/system/system_popup_header.tpl (overloaded)

<link rel="stylesheet" type="text/css" href="<{$themeUrl}>css/reset.css"> <link rel="stylesheet" type="text/css" href="<{$themeUrl}>css/xoops.css"> <link rel="stylesheet" type="text/css" href="<{$themeUrl}>css/bootstrap.min.css">

Ok, i tried to put the smarty variable <{$xswatchCss}> like this : <link rel="stylesheet" type="text/css" href="<{$themeUrl}><{$xswatchCss}>/xoops.css">

But the variable <{$xswatchCss}> is not known...

Richard (and others ;-)), i need help !

The solution is not to let the /css directory cause the system will use the /css/xoops.css for some pages (here, PM new message), but the theme used is /css-superhero/xoops.css for example.

I know, it's a long explanation, hope you undersdand what i mean !

[geekwright]

@alain01 please check out the new pull request. I think it will solve the issues you encoutered.

[alain01]

@geekwright Ok, for my tests let me show you my process :

• I renamed the /css directory in the theme to /css-todesactivate
• I checked that i get the trouble with the PM pmlite page :Yes, trouble
• Then i used your new code from the new pull request Move xswatch4 css directory selection to a separate file #816
• I checked the PM pmlite page : All is ok now
• I changed a variation in the /tpl/xswatchCss.tpl file
• Ok, new varation + ok PM pmlite page,

So, sounds good for XOOPS 2.5.11 Thank you very much @geekwright

But, for my package for xoops 2.5.10, "Houston, we 've had a problem"

Let me explain (for everyone), All is correct for XOOPS 2.5.11 now with this new pull request, We know that in several week, xoops 2.5.11 version in production will be available, But, you know that lot of webmasters will stay with XOOPS 2.5.10 for long years, may be in 2025, we could find lot of web sites with XOOPS 2.5.10.

So, in your pull request, you modify the core, (/include/fonctions.php , add " 'themePath' => $themePath, ") What do you offer to bring a solution for the xswatch4 pakage for xoops 2.5.10 ? You know, for the bt4form, i used your solution, included in my package. I hate to tell to our webmasters : "not a problem to use the xswatch4 for xoops 2.5.10, just hack the /include/fonctions.php" and all is ok !!!" I know it's easy but it's a bad way, it's a hack...

So, what coud we do for the xoops 2.5.10 webmasters ? Xswatch4 with bt4 is very powerfull and, for the XOOPS Image, it show a very powerfull and responsive design, I think it's very important !

Alain

[alain01]

Ok, GregMage found a solution for xoops 2.5.10 You can merge, it's ok for XOOPS 2. 5.11

[geekwright]

I am interested in seeing GregMage's solution. Can you link to it, please?

[alain01]

https://github.com/monxoops-fr/xswatch4-enabled It's a solution for xoops 2.5.10 (it's works for 2.511)

we reuse /css directory but see how it runs Open theses 3 files...

"21 themes in 1 theme (Preview : Bootswatch) You can pick from any of the 21 variations theme. 'cerulean' is the default thème. In the /css directory, modify the 3 files (bootstrap.min.css, cookieconsent.css and xoops.css) the string "css-cerulean" to a valid value. Valid values are:"

[alain01]

Richard, any objection that i publish a news on xswatch4-enabled for webmasters who used XOOPS 2.5.10 ? My package seems to be ready.

[geekwright]

I could not possibly object. It has been a team effort, and you have helped push it farther than I first imagined. Thank you, and all who helped!

But, I do hope you will agitate people to move to 2.5.11 when the time comes shortly. There are lots of very compelling reasons not to ignore it.

[alain01]

Yes i know. I think xswatch4-enabled is a good bridge to update to XOOPS 2.5.11. Webmasters will used this theme in x2.5.10 then update easily to 2.5.11