search

XPBytes / administrate-base_controller

:stars: Extends the ApplicationController in Administrate
MIT License
4 stars 2 forks source link

Fix index_resources (search) in administrate (0.17.0) #82

Closed gabriel closed 2 years ago

gabriel commented 2 years ago

Change from dashboard_class to dashboard.

NameError (uninitialized constant Class::ATTRIBUTE_TYPES
web     | 
web     |       @dashboard.class.const_get(:ATTRIBUTE_TYPES)
web     |                       ^^^^^^^^^^):
web     |   
web     | administrate (0.17.0) lib/administrate/search.rb:129:in `const_get'
web     | administrate (0.17.0) lib/administrate/search.rb:129:in `attribute_types'
web     | administrate (0.17.0) lib/administrate/search.rb:154:in `tables_to_join'
web     | administrate (0.17.0) lib/administrate/search.rb:116:in `search_results'
web     | administrate (0.17.0) lib/administrate/search.rb:61:in `run'
web     | administrate-base_controller (0.7.0) lib/administrate/base_controller.rb:58:in `index_resources'
web     | administrate-base_controller (0.7.0) lib/administrate/base_controller.rb:6:in `index'
SleeplessByte commented 2 years ago

I'm assuming this is because in administrate 17 dashboard_class no longer exists and was renamed?

gabriel commented 2 years ago

Yeah I think here: https://github.com/thoughtbot/administrate/commit/fd83fbbb125446f782d9713229c69dcc1d826843

SleeplessByte commented 2 years ago

I'll release as a new version so people can chose to not upgrade. For now, you can use the merge commit of this PR to load it. Thanks!