search

XPIR-team / XPIR

XPIR: Private Information Retrieval for Everyone
Other
115 stars 23 forks source link

Unused function fixed #29

Closed nicolasAmat closed 7 years ago

nicolasAmat commented 7 years ago

My PR for unused functions. Thanks

Nicolas

carlosaguilarmelchor commented 7 years ago

Your editor removed tons of white spaces. It makes reading the diff quite annoying https://github.com/XPIR-team/XPIR/pull/29/commits/2f70bb7529c755c9dce834af1298eba315722efe?diff=split Can you do a new commit without those modifications or restart a new PR (if it is easier) to avoid it ?

carlosaguilarmelchor commented 7 years ago

BTW sighandler in client/main.cpp is a function by the OS with the process receives a signal. It should not be considered as dead code.

nicolasAmat commented 7 years ago

Ok sorry ! I close the PR and I will create a new soon. Thx