search

XQF / xqf

XQF game server browser
http://xqf.github.io
GNU General Public License v2.0
37 stars 12 forks source link

Add -DWITH_QSTATCFG so users can provide an alternate qstat.cfg #218

Closed sairuk closed 5 years ago

sairuk commented 5 years ago

This addresses an issue on Debian where the git version of qstat.cfg breaks the refresh functionality for servers when used in conjunction with the packages qstat quakestat.

A Master server list will populate but xqf cannot refresh any information for individual servers.

Output to console is: /usr/local/share/xqf/qstat.cfg line 487: Unknown extend game type "tf"

This is due the packaged version of qstat (2.15-4) on Debian not supporting Titanfall and subsequently cannot extend TF for TF2 as required by the xqf included qstat.cfg.

Debian users can now compile with -DWITH_QSTATCFG=/etc/qstat.cfg to use the packaged config which doesn't include quakestat unsupported games from the upstream project.

e.g. cmake -DWITH_QSTAT=/usr/bin/quakestat -DWITH_QSTATCFG=/etc/qstat.cfg -DCMAKE_INSTALL_PREFIX=/usr ..

illwieckz commented 5 years ago

I'm afraid this can be merged. The provided qstat.cfg is only there to provide support that are not yet merged in qstat while not requiring new qstat code. Because of that the provided cfg file is always equal or more recent than the one in qstat, never older. Relying on the cfg file of an obsolete qstat may leads to some trouble in XQF. The only acceptable fix for your issue is to build a new version of qstat, it's an hard dependency after all.