XRM-OSS / Xrm-WebApi-Client

A promise-based JavaScript library for the Microsoft Dynamics CRM WebApi - TypeScript type definitions available
https://xrm-oss.github.io/Xrm-WebApi-Client/
MIT License
100 stars 28 forks source link

Don't override Promise #7

Closed DigitalFlow closed 7 years ago

DigitalFlow commented 7 years ago

While shipping bluebird is a good thing, it should be taken care of, that this does not lead to undesired side effects with other scripts, that use some other Promise library. For this purpose, bluebird should be required only in local scope and be attached to the WebApiClient, so that it can still be used like WebApiClient.Promise, which would combine polyfill shipping without possibly breaking other scripts.