XRPL-Labs / Xaman-App

Xaman (Formerly XUMM) for iOS and Android (React Native)
https://support.xumm.app
Other
104 stars 48 forks source link

Update XApp Model Window #76

Closed interc0der closed 1 year ago

interc0der commented 1 year ago

Overflow scrolling should be disabled for xApp modal windows. This would give developers the ability to define LOCAL overscroll functionality within their apps (ie. refresh page)

N3TC4T commented 1 year ago

Hi @interc0der, Thanks for the PR, do you have an example javascript code so we can test the changes and behaviour of what you described ?

interc0der commented 1 year ago

Hi @interc0der, Thanks for the PR, do you have an example javascript code so we can test the changes and behaviour of what you described ?

@N3TC4T I am going to send you a DM with a video demonstrating the issue. I would be willing to add your device to my sandboxed xApp, or make a new xApp to demonstrate and test the overscrolling.

N3TC4T commented 1 year ago

Seems problem has been solved without this code changes.