Open WietseWind opened 3 years ago
Lib built: https://github.com/XRPL-Labs/TxMutationParser
@N3TC4T Good luck 💋 😇
Nice ones to test
rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ
is not an involved party, just signing: https://bithomp.com/explorer/FF1EE042DD3B11AFA3158319D4447101FE69F62465C15A9957BD2EE0FAF35409rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ
is intermediate) https://bithomp.com/explorer/5E62A5FFFFDD29BB58139CC0D57F7CA45559674C417963F6631BC83102377E51rQamE9ddZiRZLKRAAzwGKboQ8rQHgesjEs
, sample tx: F59BBE153A4BBB9A7EFF6BA266A6C1C158828659755116D6A93FF57DA90A8241
- XUMM shows here (2.0.2) that it was an exchange, while it was just the creation of the offer: nothing was filled: https://lurxtau.dlvr.cloud/pasted_2.png - Add support for ImmediateOrCancel
and fillOrKill
order balance change display: if nothing was exchanged (didn't end up in the books): don't show the exchange for amount.Another one to test:
rwietsevLFg8XSmG3bEZzFein1g8RBqWDZ
on May 13th, two changes were proposed in #336The change on the tx details page is perfect :)
The change in the event list seems not to have came through: https://q9ged9o.dlvr.cloud/pasted_1.png
It still shows -2 XRP, while that was the delivered amount (that's right) but actually 110 XTK was sent, so if the sender is watching, it should display what was sent.
If the recipient is watching, it should display what was delivered.
Or: they can see both the same if both info is in there, e.g. like this: https://user-images.githubusercontent.com/4756161/118125830-c8144e00-b3f7-11eb-977a-93da7d3e4045.png
Note for refactoring, extra care (obviously: tx history list + tx detail, but extra tests):
Note: regular key detection from signing public key
<SIGNIFICANT CURRENCY>
: If showing the XRP value & amount is negative (sent) and theAccount
of the transaction is self, subtract theFee
Notes
Me
is not in the Balance Changes, don't show an amountAccount
orDestination
fields, show the other one (Destination
orAccount
) as source or destination, above, or under my balance change at the TX details page with a usual arrow icon.<significant currency>
in the balance changes between theAccount
andDestination
account differ, then show an exchange icon instead of usual arrow.my
(self) balance changed, but my account is not theAccount
nor theDestination
, then showAccount
as origin counterparty in the Event details. Ifmy
(self), show theAccount
above me with an arrow to me, andDestination
under me, with an arrow fromme
to Destination.offer
or it is a Payment toself
it is a trade (exchange) icon (the double arrow icon).Test transactions / accounts:
rQHYSEyxX3GKK3F6sXRvdd2NHhUqaxtC6F
torPdvC6ccq8hCdPKSPJkPmyZ4Mi1oG2FFkT
: https://bithomp.com/explorer/E788964F86299E0D5CF9ACD30D0E1DC120BBECA1AC0E10C52FED8EE8368BC9EErwietsevLFg8XSmG3bEZzFein1g8RBqWDZ
) offer: https://github.com/XRPL-Labs/XUMM-Issue-Tracker/issues/26014F19D5265191FC16260168F08C53D0B77EE54B6CF65BED5F9D15E9A6BB1E485
, showed XRP<>DKS, while it was DKS/MGT--
Outcome
Event list
Tx Details page