search

XRPL-Labs / Xaman-Issue-Tracker

Bugs, improvements, suggestions & release progress (Project boards)
https://xumm.app
14 stars 9 forks source link

[Improvement] Make preferred XRPL explorer choice available in xApp #434

Open Mwni opened 1 year ago

Mwni commented 1 year ago

This would save xApp developers the hassle of providing a dedicated XRPL explorer choice UI, or discourage them from hardcoding one particular explorer.

Ideally provided via a simple call:

> Sdk.getUserPreferredExplorer()
> 'xrpscan.com'
WietseWind commented 1 year ago

@N3TC4T I like this, for a unified experience. Especially with multi-network coming up with network specific explorer URLs/options.

In the new network specific config we already have the account & tx explorer URLs with replacement placeholder.

We could offer this as an xApp command. Thoughts?

N3TC4T commented 1 year ago

I think it's a good idea, as Custom nodes can have different explorer than what has been hard coded, it would be a good idea to provide details about explorer link for transaction and account, like how its been done here: https://github.com/XRPL-Labs/XUMM-App/blob/209cd7d869413aab252c4fd467cbc3550f65987f/src/common/utils/explorer.ts#L17

Sdk.getExplorerDetails()

{
    title: "Bithomp",
    tx: "https://bithomp.com/explorer/";
    account: "https://bithomp.com/explorer/;
}