XRPL-Labs / Xaman-Issue-Tracker

Bugs, improvements, suggestions & release progress (Project boards)
https://xumm.app
13 stars 11 forks source link

[Feature] Add support to view payment channels within Xumm app #449

Open desimmons opened 11 months ago

desimmons commented 11 months ago

Feature description

Ticket made in response to Tweet here. Support for viewing currently open payment channels would be desirable:

The view would likely need to support the following core functionality:

  1. Ability to open new payment channels
  2. Ability create close payment channel requests
  3. Ability to sign a new claim against a particular payment channel
  4. Ability to view all active payment channels as per image below:

Untitled-2023-08-02-2101

WietseWind commented 11 months ago

Great way to visually represent channels. I'd say the same could even be applied to Escrow duration, offer filling, etc.

Will be discussed internally! Thanks!

desimmons commented 11 months ago

@WietseWind

We're building an API marketplace powered by XRPL payment channels. If you think our involvement in the dev of this feature would be important/valuable, please feel free to reach out.

You can find out more technical details on our project's current state here

DJ-xrpl commented 11 months ago

@desimmons thanks for the idea. I'll put it on my to-list for the coming period (^__^)/

DJ-xrpl commented 11 months ago

13 Pro - 93 Here's an example @WietseWind @N3TC4T @desimmons @technotip =]

WietseWind commented 11 months ago

That's about it, nice! I think the colour shouldn't be green/red (it isn't good or bad that it's spent) & it should also be on the event details page.

desimmons commented 11 months ago

This looks amazing!

I'm not sure how to interpret the multiple Netflix channels here though. It'd be nice if there was an ability to close and top-up the channels too.

I've also realised, in the "Events" page on my Xumm wallet, I currently have a payment channel open and this is visible through the "Planned" tab but not through the "All" tab

WietseWind commented 11 months ago

@desimmons They are just for illustration, they can be from any source.

Regarding top up and close: that's something that belongs on the detail page, so you would tap the item in the list, just like a transaction / escrow / ... and then get presented appropriate follow up actions on the detail page.

The channel is in the All tab at the moment of creation: the creation of the channel. The Planned tab shows all the objects that can/will mean something to you now or in the future. They are separate things. The All tab shows transactions, the Planned tab shows existing ledger objects owned by your account.

DJ-xrpl commented 11 months ago

@desimmons @WietseWind don't be fooled by the many Netflixes xD The goal was to show different kind of visualisations on how much xrp you have used/have left. Personally I'm fan that says "13 XRP left".