search

XRPL-Labs / verify-xrpl-signature

Verify XRPL signed TX blob (node)
MIT License
7 stars 6 forks source link

Cannot find module 'ripple-binary-codec' #15

Open qheolet opened 1 year ago

qheolet commented 1 year ago

Hello guys I am building a CLI in Deno just for fun and I got error:

Uncaught Error: Cannot find module 'ripple-binary-codec' Require stack: - /Users/Juan.Duran1/Library/Caches/deno/npm/registry.npmjs.org/verify-xrpl-signature/1.0.0/dist/index.js

I think is because: in the package.json that library is bring as override any idea how i can fix this. 


  "overrides": {
    "ripple-binary-codec": "npm:xrpl-binary-codec-prerelease@2.0.0"
  },

THANKS!!

WietseWind commented 1 year ago

Hi,

As far as I am aware, Deno doesn't support overrides. We need the override as we use certain features not available in mainline ripple-binary-codec yet.

So for now the solution would be to update the package.json to point to the aforementioned package directly, and in the near future if we can point back to mainline again this will be solved altogether.

^^ Neither will work with push to deploy / remote deployment solutions. But locally either one, or even symlinking the source repo to a checkout of the mentioned override package should work.

qheolet commented 1 year ago

Thanks, Looking forward.