XRPL-Labs / xapp-builder

MIT License
2 stars 0 forks source link

Disallow closing the Debug panel #9

Closed WietseWind closed 1 year ago

WietseWind commented 1 year ago

The debug panel can currently be closed:

image

Either remove the close feature, or if impossible: show a button to open it again.

technotip commented 1 year ago

The close feature can not be removed.

But we can either have a DevTool Toggle Button in the menu or close the entire app when the x button is clicked. Closing the app when someone clicks x almost feels like a native functionality, even though it is not! That way, user can not close the DevTool.

Screenshot 2023-05-05 at 10 12 16 PM
WietseWind commented 1 year ago

close the entire app when the x button is clicked. Closing the app when someone clicks x almost feels like a native functionality, even though it is not! That way, user can not close the DevTool.

This is the way :)

But... That means you can detect it's clicked and closed? And you can also programmatically open it again?

In that case: just detect and re-open on close?

technotip commented 1 year ago

But... That means you can detect it's clicked and closed? And you can also programmatically open it again? In that case: just detect and re-open on close?

I tried that, but to re-open it the whole window has to be re-rendered. It doesn't look very good. But the main problem is, sometimes it produces multiple instances of the app.

WietseWind commented 1 year ago

Hmm in that case just close the entire thing indeed. An xApp builder/debugger without debugger console is nothing, devs will understand.

technotip commented 1 year ago

Finally implemented the re-opening of console window automatically if the user closes it. 🎉

xAppBuilder

WietseWind commented 1 year ago

Wonderful! Exactly what I hoped for :)