XRPL-Labs / xrpld-hooks

ISC License
94 stars 28 forks source link

Firewall Hook Fails #25

Closed dangell7 closed 2 years ago

dangell7 commented 2 years ago

Issue Description

The firewall hook gives me this error: Blacklist: Memo public key wrong length.

Steps to Reproduce

First off, I think the example is incorrect? In the firewall.c it says the blacklist account is rno8D3qi5VrBvxTUE7nsem5kcJDnQUooQy. But when I go to the blacklist.c file the seed, PK, and PKK all point to the account rffs6t1RN4JUTC5c3TpYQweABa47wjPacE.

So is the blacklist account the hook account which is NOT the same as the public key attached to the blacklist hook?

Here is what I did.

  1. New funded key pair account.
  2. Convert public key to hexdecimal and insert in blacklist.c
  3. Add new address in firewall.c
  4. Make
  5. Add Blacklist Hook
  6. block-unblock and here is where I get the Blacklist: Memo public key wrong length.

Expected Result

Add address to blocked list

Actual Result

Blacklist: Memo public key wrong length.

I personally run a docker-compose and then use XRPL.py and my code is exactly as the js code. I admit it could be an issue with my code. But I cannot test the blacklist.c because if I use the secret stored in the blacklist.c file which matches the public key, I get an account not found error.

dangell7 commented 2 years ago

Looks like I was wrong.