search

XRPLF / XRPL-Standards

XLS: XRP(L) community defined Suggestions, Proposals, RFCs / Standards / Drafts & discussions, to be added to the core protocol, used for platform & apps devemopment, etc.
MIT License
187 stars 48 forks source link

XLS-0033d-CFTs: Make AssetScale optional #127

Closed sappenin closed 10 months ago

sappenin commented 1 year ago

Per this PR comment, this change makes AssetScale optionally supplied in CFTokenIssuanceCreate transactions.

sappenin commented 1 year ago

I think this is fine, but why is it called AssetScale? Does it have the same purpose/meaning as ERC-20's decimals?

Yes, I think the two meanings are the same. What do you think about also using Symbol instead of AssetCode?

intelliot commented 1 year ago

Yes, I think the two meanings are the same. What do you think about also using Symbol instead of AssetCode?

Sounds good to me!

sappenin commented 1 year ago

https://github.com/XRPLF/XRPL-Standards/pull/127#issuecomment-1680921275

@ledhed2222 @nkramer44 @seelabs Any opinion on this terminology change?

ledhed2222 commented 1 year ago

actually - i've incorporated this into my other PR https://github.com/XRPLF/XRPL-Standards/pull/123

since that hasn't been reviewed yet, let's make it a place for ongoing changes rather than having multiple open PRs in this repo

sappenin commented 1 year ago

actually - i've incorporated this into my other PR https://github.com/XRPLF/XRPL-Standards/pull/123 Since that hasn't been reviewed yet, let's make it a place for ongoing changes rather than having multiple open PRs in this repo

Sounds great, closing this PR in favor of https://github.com/XRPLF/XRPL-Standards/pull/123

sappenin commented 1 year ago

@ledhed2222 - given that there's a lot of discussion in your new CFT spec PR, how do you feel about me re-opening this one so we don't have a bunch of open issues being debated in one place (i.e., your other PR)?

(Trying to reduce as much noise as possible).

sappenin commented 10 months ago

Closing this PR in-favor of https://github.com/XRPLF/XRPL-Standards/pull/137, which has everything in this PR.