XLS-40: DID Specification

XRPLF / XRPL-Standards

XLS: XRP(L) community defined Suggestions, Proposals, RFCs / Standards / Drafts & discussions, to be added to the core protocol, used for platform & apps devemopment, etc.

MIT License

191 stars 52 forks source link

XLS-40: DID Specification #136

Closed aanchal4 closed 1 year ago

aanchal4 commented 1 year ago

Final XLS-40 Spec

Prior discussion can be found here https://github.com/XRPLF/XRPL-Standards/discussions/100
Implementation: https://github.com/XRPLF/rippled/pull/4636/

shortthefomo commented 1 year ago

Maybe I'm just reading it wrong by why is the id of the did not present in the account_objects response? Also the delete I don't see a parameter to delete by id...

Forgive me if wrong viewing this on mobile.

mvadari commented 1 year ago

Maybe I'm just reading it wrong by why is the id of the did not present in the account_objects response?

It looks like @aanchal4 just wrote an overly simplified version of what account_objects returns (note that the request doesn't even include an account param) - the actual response will contain all the usual fields.

Also the delete I don't see a parameter to delete by id...

A user can only hold one DID object. So no ID is needed - you're just deleting the one object they have.

intelliot commented 1 year ago

@mvadari @sappenin - can you connect with @aanchal4 if your comments haven't been addressed?

sappenin commented 1 year ago

@Silkjaer can you take another look here? This has pretty broad approval otherwise.

intelliot commented 1 year ago

note: @aanchal4 confirmed this should be ready to merge