search

XRPLF / XRPL-Standards

XLS: XRP(L) community defined Suggestions, Proposals, RFCs / Standards / Drafts & discussions, to be added to the core protocol, used for platform & apps devemopment, etc.
MIT License
191 stars 52 forks source link

Information on AMM and Clawback collaboration #141

Closed tequdev closed 1 year ago

tequdev commented 1 year ago

It is not clearly stated that AMM pools cannot be created with tokens that have Clawback enabled.

mvadari commented 1 year ago

It's listed here: https://github.com/XRPLF/XRPL-Standards/tree/master/XLS-0039d-clawback#7-compatibility-with-automated-market-maker-xls-30

tequdev commented 1 year ago

This statement gives the perception that it is possible to create an AMM pool with Clawbackable tokens, but it is not possible to Clawback from the AMM pool.

A statement regarding AMMCreate transactions is needed.

kennyzlei commented 1 year ago

Thanks for catching this! We can update the Clawback spec to explicitly state this. I believe this Clawback spec was derived before the AMMCreate behavior was fully finalized, and now we can update the spec to define the behavior clearer

mDuo13 commented 1 year ago

https://github.com/XRPLF/xrpl-dev-portal/pull/2245 fixes this on the dev portal