search

XRPLF / XRPL-Standards

XLS: XRP(L) community defined Suggestions, Proposals, RFCs / Standards / Drafts & discussions, to be added to the core protocol, used for platform & apps devemopment, etc.
MIT License
191 stars 52 forks source link

XLS-69d: Simulate #207

Closed mvadari closed 3 months ago

mvadari commented 4 months ago

Discussion thread can be found here: https://github.com/XRPLF/XRPL-Standards/discussions/199

intelliot commented 3 months ago

I think we may want to consider changing/updating this to use the API version 2 format.

(Unrelated: Outside the scope of this spec, I noticed the docs have not yet been updated for API version 2, so I opened this: https://github.com/XRPLF/xrpl-dev-portal/issues/2693)

mvadari commented 3 months ago

I think we may want to consider changing/updating this to use the API version 2 format.

Is there some part of the spec that doesn't use the APIv2 format? I thought I got everything.

intelliot commented 3 months ago

I think the Example Response should be updated to have the transaction data moved under tx_json

mvadari commented 3 months ago

I think the Example Response should be updated to have the transaction data moved under tx_json

It already is.

I've made some changes to this version that aren't in the discussion, btw.

mvadari commented 3 months ago

@sappenin this is ready to merge.