Closed godexsoft closed 2 months ago
Attention: Patch coverage is 53.84615%
with 12 lines
in your changes are missing coverage. Please review.
Project coverage is 64.45%. Comparing base (
82b8316
) to head (a5769d9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Nice wrote !
Found an edge case, please recheck if it is valid.
I am still thinking we should disable all cache usage or just for ETL? 🤔
If we disable all cache usage, it makes the problem visible to users. Maybe it is better choice. But it indeed affects the performance.
Nice wrote ! Found an edge case, please recheck if it is valid. I am still thinking we should disable all cache usage or just for ETL? 🤔 If we disable all cache usage, it makes the problem visible to users. Maybe it is better choice. But it indeed affects the performance.
I'd think let's disable it entirely for now. If we find it become an issue we can always adjust it later.
For #1354
This is the first part of the issue. The second part will have to wait and be implemented once we have SHAMap available as a library in Clio.