Closed mounikakun closed 3 weeks ago
Clio returns invalidParams whereas rippled returns oracleMalformed with malformed trim values in get_aggregate_price
invalidParams
oracleMalformed
""
-1
abc
Request:
{ "method": "get_aggregate_price", "params": [ { "base_asset": "BTC", "quote_asset": "ETH", "trim": "", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ] } ] }
Rippled response:
{ "result": { "error": "oracleMalformed", "error_code": 94, "error_message": "Oracle request is malformed.", "request": { "base_asset": "BTC", "command": "get_aggregate_price", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ], "quote_asset": "ETH", "trim": "" }, "status": "error" } }
Clio response:
{ "result": { "error": "invalidParams", "error_code": 31, "error_message": "Invalid parameters.", "status": "error", "type": "response", "request": { "method": "get_aggregate_price", "params": [ { "base_asset": "BTC", "quote_asset": "ETH", "trim": "", "oracles": [ { "account": "rwz8i5bUKa12tYxQjsSuzDQaBwKkuGUqa5", "oracle_document_id": 1 }, { "account": "rDtBhKmzKveCSd5jmrcQD6CU8kidCLCy7h", "oracle_document_id": 1 } ] } ] } }, "warnings": [ { "id": 2001, "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request" } ] }
According to SPEC We should return error when trim is invalid uint.
Issue is fixed on rippled end so no need to fix on Clio end.
Issue Description
Clio returns
invalidParams
whereas rippled returnsoracleMalformed
with malformed trim values in get_aggregate_priceSteps to Reproduce
""
,-1
,abc
Request:
Expected Result
Rippled response:
Actual Result
Clio response:
Environment
Supporting Files