Closed mounikakun closed 1 week ago
I think Clio's response (invalidParams) maybe more descriptive.
Issue is fixed on rippled end for the below invalid test data.
None, "Invalid", 123, -1, 0, 1.2, "H", "HB", "HBAR", "", _INVALID_NON_STANDARD_CURRENCY_CODE_:"0158415500000000C1F76FF6ECB0BAC600000000A"
objectNotFound
remains same for the below cases
VALID_NON_STANDARD_CURRENCY_CODE = "0158415500000000C1F76FF6ECB0BAC600000000", "HBA"
Clio is not replicating invalidParams
error for below test data
"Invalid", _INVALID_NON_STANDARD_CURRENCY_CODE_:"0158415500000000C1F76FF6ECB0BAC600000000A", "H", "HB", "HBAR", ""
Issue still exists for empty ""
values of base_asset
empty base_asset request:
{"method": "get_aggregate_price", "params": [{"base_asset": "", "quote_asset": "ETH", "oracles": [{"account": "rDvpETjjxp4KH6RzyMBCHkxs6p9y7taecG", "oracle_document_id": 1}, {"account": "rNpPJMYRmnfVNUgXv6X1pn93WkNzchNwnS", "oracle_document_id": 1}], "Fee": "20"}]}
rippled response:
{
"result": {
"error": "invalidParams",
"error_code": 31,
"error_message": "Invalid parameters.",
"request": {
"Fee": "20",
"base_asset": "",
"command": "get_aggregate_price",
"oracles": [
{
"account": "rDvpETjjxp4KH6RzyMBCHkxs6p9y7taecG",
"oracle_document_id": 1
},
{
"account": "rNpPJMYRmnfVNUgXv6X1pn93WkNzchNwnS",
"oracle_document_id": 1
}
],
"quote_asset": "ETH"
},
"status": "error"
}
}
clio response:
{
"result": {
"error": "objectNotFound",
"error_code": 92,
"error_message": "The requested object was not found.",
"status": "error",
"type": "response",
"request": {
"method": "get_aggregate_price",
"params": [
{
"base_asset": "",
"quote_asset": "ETH",
"oracles": [
{
"account": "rDvpETjjxp4KH6RzyMBCHkxs6p9y7taecG",
"oracle_document_id": 1
},
{
"account": "rNpPJMYRmnfVNUgXv6X1pn93WkNzchNwnS",
"oracle_document_id": 1
}
],
"Fee": "20"
}
]
}
},
"warnings": [
{
"id": 2001,
"message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request"
}
]
}
Fixed by #1481
Issue Description
Clio returns
invalidParams
whereas rippled returnsobjectNotFound
with malformed base_asset values in get_aggregate_priceSteps to Reproduce
123
,-1
,0
,1.2
Request:
Expected Result
Rippled response:
Actual Result
Clio response:
Environment
Supporting Files