search

XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
56 stars 48 forks source link

Static linkage #1377

Closed godexsoft closed 2 months ago

godexsoft commented 2 months ago

Fixes #1300

Adds a static option for both conan and cmake. Uses the option on CI for all linux builds. Note: static linkage not currently supported for AppleClang path.

I'm not too happy about adding flags like -static manually but that's the best way i found to achieve what we wanted. If you know a more cmake-y way of doing it please do let me know 👍

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.45%. Comparing base (c00342c) to head (961c1e1).

:exclamation: Current head 961c1e1 differs from pull request most recent head ab9d48a. Consider uploading reports for the commit ab9d48a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1377 +/- ## =========================================== - Coverage 64.51% 64.45% -0.06% =========================================== Files 251 251 Lines 10598 10598 Branches 5866 5866 =========================================== - Hits 6837 6831 -6 - Misses 1910 1916 +6 Partials 1851 1851 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.