search

XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
56 stars 48 forks source link

Combine requestStop and cancel as abort #1379

Closed godexsoft closed 2 months ago

godexsoft commented 2 months ago

Fixes #1367

This does not implement the stopToken.reason() idea from the issue as we decided to leave that for a later day.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.52%. Comparing base (8f47128) to head (cf7942d).

:exclamation: Current head cf7942d differs from pull request most recent head c6444dc. Consider uploading reports for the commit c6444dc to get more accurate results

Files Patch % Lines
src/util/SignalsHandler.cpp 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1379 +/- ## =========================================== + Coverage 64.48% 64.52% +0.04% =========================================== Files 251 251 Lines 10589 10585 -4 Branches 5860 5860 =========================================== + Hits 6828 6830 +2 + Misses 1910 1904 -6 Partials 1851 1851 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.