Closed cindyyan317 closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 64.51%. Comparing base (
b18d73e
) to head (c1f6c2f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ouch. The two most common mistakes in programming: syntax errors, error handling, and off-by-one errors.
Should this be removed as well? or is the logic somehow different for fetchNFTTransactions
? https://github.com/XRPLF/clio/blob/c1f6c2f983a9ff8253cef9501f09513a1ac61cbb/src/data/CassandraBackend.hpp#L444-L448
Ouch. The two most common mistakes in programming: syntax errors, error handling, and off-by-one errors.
Should this be removed as well? or is the logic somehow different for
fetchNFTTransactions
?
Thanks for pointing it out. This logic is okay. Because the cql is using ">=". To avoid same transaction being returned, +1 is correct. https://github.com/XRPLF/clio/blob/develop/src/data/cassandra/Schema.hpp#L597 is using ">" , +1 is not necessary.
Since our selectAccountTxForward is no longer inclusive, we should adjust this place. Fix #1389