XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
55 stars 48 forks source link

Date of commit in version string; No git hash in release version #1409

Closed legleux closed 1 month ago

legleux commented 1 month ago

A release's version string should be a signed annotated tag which Clio has generally been following.

Uses the date of the commit since that seems like a more useful item to track to not have identical source builds have different version strings.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.80%. Comparing base (99400d7) to head (5130f16). Report is 1 commits behind head on develop.

:exclamation: Current head 5130f16 differs from pull request most recent head d6b4d4d

Please upload reports for the commit d6b4d4d to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1409 +/- ## ======================================== Coverage 67.80% 67.80% ======================================== Files 232 232 Lines 9309 9309 Branches 5203 5203 ======================================== Hits 6312 6312 + Misses 1639 1638 -1 - Partials 1358 1359 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.