search

XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
55 stars 48 forks source link

Forward feature RPC #1440

Closed godexsoft closed 2 weeks ago

godexsoft commented 1 month ago

Fixes #1436

This is a temporary implementation of the feature RPC that will always return noPermission iff vetoed is set. If vetoed isn't specified, Clio will always forward the request to rippled instead.

In the future, #1131 will implement a Clio-native feature RPC. This requires specific support from libxrpl side and that is not going to be available till at least 2.2.1, hence the temporary forwarding.

It would be great to review the error message and code so that we pick the right one from the start.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 31.81818% with 15 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (1125b09) to head (8aefb3a).

Files Patch % Lines
src/rpc/handlers/Feature.cpp 22.22% 13 Missing and 1 partial :warning:
src/rpc/common/impl/HandlerProvider.cpp 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1440 +/- ## =========================================== - Coverage 67.89% 67.76% -0.14% =========================================== Files 232 233 +1 Lines 9337 9358 +21 Branches 5211 5219 +8 =========================================== + Hits 6339 6341 +2 - Misses 1638 1654 +16 - Partials 1360 1363 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.