search

XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
61 stars 52 forks source link

Support string type integer for oracle_document_id #1448

Closed cindyyan317 closed 3 months ago

cindyyan317 commented 3 months ago

Seems like rippled supports string-type int for integer field of input json, Clio will starts supporting it.

This PR changed the field oracle_document_id to support both integer type and integer but string-type. For example 1 and "1".

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (d39fb20) to head (c76fb74). Report is 4 commits behind head on develop.

Files Patch % Lines
src/rpc/common/Modifiers.hpp 58.82% 0 Missing and 7 partials :warning:
src/rpc/common/MetaProcessors.hpp 40.00% 0 Missing and 6 partials :warning:
src/rpc/handlers/GetAggregatePrice.hpp 37.50% 1 Missing and 4 partials :warning:
src/rpc/common/Validators.cpp 33.33% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1448 +/- ## =========================================== - Coverage 67.89% 67.74% -0.15% =========================================== Files 232 233 +1 Lines 9337 9387 +50 Branches 5211 5232 +21 =========================================== + Hits 6339 6359 +20 - Misses 1638 1652 +14 - Partials 1360 1376 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.