XRPLF / clio

An XRP Ledger API Server
https://xrpl.org
ISC License
56 stars 48 forks source link

"account_nfts" with unassociated marker is returning empty account_nfts instead of error. #1497

Open mounikakun opened 5 days ago

mounikakun commented 5 days ago

Issue Description

"account_nfts" with unassociated marker(i.e., marker from another method "account_channels") is not returning error.

Not sure if the response should error out or return empty account_nfts. As rippled is fixing the issue, will have to replicate it in Clio.

Steps to Reproduce

Sample request: { "method": "account_nfts", "params": [ { "account":"ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM", "marker": "10394D3EA937A85A4482D2071412A33C8582A6EB4C3B7FD59C76012D83AC08C6" } ] }

Expected Result

Current response matches with rippled. If there's a fix for https://github.com/XRPLF/rippled/issues/4314 which returns error, Clio should replicate it.

Actual Result

{ "result": { "ledger_hash": "41560CD72E0E9B68BC8D9A8E261695392C22B3E115E0796119DC40B28C26E242", "ledger_index": 1936194, "validated": true, "account": "ra1egD7jzyZWhcDaPD1eFPKzdSMVQCTsXM", "account_nfts": [], "limit": 100, "status": "success" }, "warnings": [ { "id": 2001, "message": "This is a clio server. clio only serves validated data. If you want to talk to rippled, include 'ledger_index':'current' in your request" } ] }

Environment

Supporting Files