search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.52k stars 1.47k forks source link

purge /etc/opt/ripple from configs/setup #2916

Open mellery451 opened 5 years ago

mellery451 commented 5 years ago

The packages currently install files to /opt/ripple, but then also create a few symlinks in /etc/opt/ripple (pointing to config files in /opt/ripple/etc).

Proposal: eliminate the symlinks and just stick with the /opt/ripple paths. Any files and search logic that considers looks for configs in /etc would need to change.

alloynetworks commented 5 years ago

The rippled binary looks for the config in the symlink under /etc/opt as default - that would need to change. The other is the init file. The rest are all packaging related references.

MarkusTeufelberger commented 5 years ago

It would be nice if the binary would first look under /etc/rippled actually and then /opt/rippled/etc...

alloynetworks commented 5 years ago

Right now I think we look at pwd and then /etc/opt/ripple . Would it make sense to look at an ENV variable and then /opt/rippled/etc ? This could allow for customization without adding multiple search paths to the code.

MarkusTeufelberger commented 5 years ago

Eventually rippled hopefully actually makes it into other distributions than Alpine as well, so having /etc/rippled in the search path makes it much easier for users and packagers alike. Otherwise one either needs to patch the code before compiling or do other things (such as set an environment variable) just to read the config from the main config folder in Linux distros.

intelliot commented 1 year ago

@thejohnfreeman At your convenience, could you check if any of the suggestions above are still worth considering? If not, go ahead and close this issue.