XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.52k stars 1.46k forks source link

Remove `wallet_propose` method (Version: *) #3395

Open WietseWind opened 4 years ago

WietseWind commented 4 years ago

Summary

Rippled implements the wallet_propose method. I feel it may be a good idea to remove this from rippled and move it to a separate tool.

Motivation

There are many secret/seed/... formats/methods to generate accounts going around, like:

I feel it would be better to have a small, standalone tool for account generation (proposing "wallets") than this being part of rippled.

Solution

Remove & standalone tool implementing multiple formats/methods to generate accounts

intelliot commented 4 years ago

Sounds reasonable; the first step here would be to create / document the standalone tool and make sure it serves all the use cases that wallet_propose did.

MarkusTeufelberger commented 4 years ago

As long as the "standalone" tool is truly standalone (a single binary, not something JavaScript with a few GB of node_modules) sure, why not.

brandon-bb commented 1 year ago

I would like to work on this, could you assign this to me please?