search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.5k stars 1.46k forks source link

Recommendations for BUILD.md #4554

Open intelliot opened 1 year ago

intelliot commented 1 year ago

A few recommendations:

  1. When building on Apple M silicon, I believe that the Conan install option --build missing needs to be changed to just --build.

  2. I recommend adding an example to the options section that shows how to use an option. Perhaps:

    cmake -DCMAKE_TOOLCHAIN_FILE: ... -Dassert=ON

  3. One can confirm how options are currently set in CMakeCache.txt

Originally posted by @HowardHinnant in https://github.com/XRPLF/rippled/pull/4514#pullrequestreview-1451591681

AnmolSirola commented 1 year ago

@intelliot Is anyone working on this issue ?

intelliot commented 1 year ago

@AnmolSirola No, not that I am aware of. You are welcome to take it!