Document reduce-relay features and decide whether more experimentation is needed

intelliot commented 1 year ago

Summary

There are reduce-relay features which are currently considered experimental.

https://github.com/XRPLF/rippled/blob/aded4a7a925a5822522e6bbbb4adfd3fec39257b/src/ripple/core/Config.h#L250-L277

Document the features so that more developers and node operators are aware of them and can understand them.
Related blog post: https://xrpl.org/blog/2021/message-routing-optimizations-pt-1-proposal-validation-relaying.html
- (There is a draft for Pt. 2 which @gregtatcam will revisit and consider posting)
Define what we intend to learn from the experiment. (See blog)
Consider moving the feature(s) to the next stage, for features that should move forward (beyond experimental).

Motivation

Bandwidth savings and network efficiency, and reduce CPU usage since fewer messages are sent. Possible overall performance improvement.

Solution

Reduce redundant/unnecessary relay of messages

Paths Not Taken

?

gregtatcam commented 1 year ago

There is zero adaption of this features by the servers. Perhaps we should keep it experimental and not documented until more tests are done.

ximinez commented 1 year ago

There is zero adaption of this features by the servers. Perhaps we should keep it experimental and not documented until more tests are done.

OTOH, documenting it might help increase adoption, letting more people test. If there are problems, testing live will surely find them quickly, letting folks report them. They can always turn it back off if there are significant problems.

gregtatcam commented 1 year ago

OTOH, documenting it might help increase adoption, letting more people test. If there are problems, testing live will surely find them quickly, letting folks report them. They can always turn it back off if there are significant problems.

I'm just thinking that it might make sense to spend a couple of weeks replicating some tests that I've ran before and see if the main premise of saving on the bandwidth and not having any degradation due to reduce message flooding still holds. These features were added over two years ago.

XRPLF / rippled