Open mDuo13 opened 8 months ago
Could we just document that the ctid must be in uppercase?
nit: I noticed under "Actual Result", you have: "ctid": "c005523e00000000",
(lowercase leading c
) but when I tried it in the websocket tool, it correctly echoes back the provided capitalization - i.e. "ctid": "C005523e00000000",
I was planning on documenting the behavior, but case-sensitive hexadecimal is annoying and easy to get wrong/forget. For example, I constructed a CTID partly using Python's binascii.hexlify
standard lib function and it generated lowercase hex by default, which I didn't realize would be a problem. And the "invalid params" error is unhelpfully vague since it also applies if you're on a server that doesn't support CTIDs at all (e.g. the Clio servers behind s1), or if you used the wrong field or whatever else.
re: the "actual result" example, I accidentally pasted the wrong example response (as you noted, it appropriately echoes back what you put in)
Definitely agree that the error message isn't helpful. I guess the purist in me would prefer that everyone just use uppercase hex for consistency, but I think it should also be fine to be permissive here.
Issue Description
The
ctid
field of thetx
command, added in #4418, does not work if the given CTID contains lowercase hex.Steps to Reproduce
Send this request to a rippled 1.12 server.
Expected Result
Request should successfully find transaction E08D6E9754025BA2534A78707605E0601F03ACE063687A0CA1BDDACFCD1698C7 like this example. Aside from the ID, the difference is the
e
vsE
in the CTID.Actual Result
Response is an
invalidParams
error message.Environment
rippled 1.12.0 via xrplcluster.com