search

XRPLF / rippled

Decentralized cryptocurrency blockchain daemon implementing the XRP Ledger protocol in C++
https://xrpl.org
ISC License
4.51k stars 1.46k forks source link

Validation stream Network ID (Version: 1.12.0) #4783

Open shortthefomo opened 11 months ago

shortthefomo commented 11 months ago

Summary

Network id is impossible to establish from the validation stream, the stream contains validators of all networks.

Motivation

Explorers, hosting tools, etc. Or anything try to validate data out of this stream will need to figure out which network the node is on.

Solution

Add a network_id field to the validation data returned in the stream of data https://xrpl.org/subscribe.html#validations-stream

Paths Not Taken

Unable to 100% say if the id is present in another hash or it could possibly be derived from something already present.

intelliot commented 10 months ago

Additionally/ideally, there would be no crosstalk between networks. Nodes should not connect to, nor gossip messages from, nodes on other networks.

pkcs8 commented 7 months ago

+1 from my side. Adding NetworkID to the validation stream would clean up a lot of code that consumes validations.

mvadari commented 7 months ago

It would also be nice if this could be added to the ledger stream, if you're listening to multiple networks.